search

status-im / nim-stew

stew is collection of utilities, std library extensions and budding libraries that are frequently used at Status, but are too small to deserve their own git repository.
133 stars 18 forks source link

fix results compiletime regression #203

Closed jangko closed 1 year ago

jangko commented 1 year ago

fix #202

jangko commented 1 year ago

hmm, turn out the other func value also regress for nim 1.2 and 1.4 but not tested before.

tersec commented 1 year ago

I'm all for green CI, but, in this case, is this just creating silent brokenness in pre-Nim-1.6?

My suggested response to https://github.com/status-im/nim-stew/pull/203/commits/1b2c0be6a00a9f05c8c6c14bc2e2f8ba77cb4b26 is more along the lines of https://github.com/status-im/nim-stew/pull/204 -- if it's known broken without feasibility of fixing it, then it's not really a supported target.

And, while it might be possible to fix this so that it still works on Nim 1.2/1.4, just, why?

arnetheduck commented 1 year ago

is this just creating silent brokenness in pre-Nim-1.6?

this is an example of partial support - ie most of it works but compile-time has issues - worth keeping in mind here is that when we talk about supporting 1.6, most of the 1.6 releases actually don't work (only the newer ones).