fix failure with devel after stricteffects enabled, fix #56

[pietroppeter]

see #56

[pietroppeter]

I am expecting error reported in #56 to show when CI runs. not sure how to proceed with fixing the new error

[jangko]

instead of using nosideeffect pragma, it will be cleaner and shorter to use func to replace the proc.

the unlisted exception indeed annoying because we are not sure where to look into for the source of exception.

[pietroppeter]

• changed annotated proc to func
• manually track exceptions as in #55 (following a suggestion from @ringabout)
• I could add a protection by nim version (apply last change on tracking exceptions only for >= 1.7) but for the moment the simple example above compiles with both devel and stable (using choosenim locally)
• although locally nimble test fails with not a particularly revealing stack trace:

  [NimScript] exec: nim cpp --threads:off -d:release --outdir:build -r --hints:off --skipParentCfg --styleCheck:usages --styleCheck:error tests/test_all
  Error: execution of an external program failed: 'C:\Users\ppeterlongo\Documents\toml_serialization\build\test_all.exe'
  stack trace: (most recent call last)
  C:\Users\PPETER~1\AppData\Local\Temp\nimblecache-0\nimscriptapi_403350235.nim(187, 16)
  C:\Users\ppeterlongo\Documents\toml_serialization\toml_serialization.nimble(49, 8) testTask
  C:\Users\ppeterlongo\Documents\toml_serialization\toml_serialization.nimble(42, 8) test
  C:\Users\ppeterlongo\.choosenim\toolchains\nim-#devel\lib\system\nimscript.nim(264, 7) exec
  C:\Users\ppeterlongo\.choosenim\toolchains\nim-#devel\lib\system\nimscript.nim(264, 7) Error: unhandled exception: FAILED: nim cpp --threads:off -d:release --outdir:build -r --hints:off --skipParentCfg --styleCheck:usages 
  --styleCheck:error tests/test_all [OSError]
   Error: Exception raised during nimble script execution

[arnetheduck]

nimble test fails

what about running nim cpp --threads:off -d:release --outdir:build -r --hints:off --skipParentCfg --styleCheck:usages --styleCheck:error tests/test_all manually?

[pietroppeter]

nimble test fails

what about running nim cpp --threads:off -d:release --outdir:build -r --hints:off --skipParentCfg --styleCheck:usages --styleCheck:error tests/test_all manually?

I did but it does not provides additional info

[pietroppeter]

ok, looking at some of the failing checks I can see that in some cases (e.g. windows-amd64-c-(Nim-version-1-6), but also linux and possibly others) an error is reported during compilation:

/home/runner/work/nim-toml-serialization/nim-toml-serialization/nim-toml-serialization/toml_serialization/private/array_reader.nim(40, 12) Error: 'readArray' is not GC-safe as it calls 'readValue'

in other cases (in particular at least some of those using devel, which include my local setup of windows-amd64), the error is not reported during compilation and running fails without a stacktrace.

[Menduist]

This should help: https://github.com/status-im/nim-serialization/pull/44 Managed to compile with the linked fix + {.push gcsafe.} at the beginning of lexer.nim & reader.nim (or one brave soul could add gcsafe to each readValue & parseValue)

Then the test segfaults, probably a orc bug / incompatibility.

[pietroppeter]

I see this has been merged (while still failing), assuming maintainers will take over from here (fine with me! ;))

[jangko]

until issue in nim-serialization solved, https://github.com/status-im/nim-serialization/issues/45, we cannot do much to remove the segfaults.