search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
521 stars 223 forks source link

Spadina - EIP2333 update? #1722

Closed mratsim closed 3 years ago

mratsim commented 3 years ago

For release tracking

EIP2333 has been updated with non-backward compatible key generation changes.

The change is somewhat trivial https://github.com/ethereum/EIPs/pull/2985/files, it just loop if someone generated a 0 secret key (with 2^-255 probability)

In terms of timing we need to know if we have to release it for Spadina, see https://github.com/ethereum/eth2.0-deposit-cli/pull/108#issuecomment-696509418

CarlBeek commented 3 years ago

Indeed the change is trivial to implement, yet unfortunately it is still not backwards compatible. (See the discussion on the BLS specs repo for why.)

For Spadina, the CLI will be using the updated EIP2333 key generation as discussed in https://github.com/ethereum/eth2.0-deposit-cli/pull/108#issuecomment-696630501

mratsim commented 3 years ago

Closed by #1742