status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
543 stars 233 forks source link

Logs & metrics for gossipsub publishes when the amount of peers subscribed is low/none #2161

Closed kdeme closed 3 years ago

kdeme commented 3 years ago

We should have a way to track when a message is published to a topic but when the node wasn't connected to any or only a low amount of peers that were subscribed to that topic.

This would be specifically useful for tracking missed attestations as why they occurred (e.g. no or low amount of peers on that attestation subnet). And it would be quite necessary when testing and tuning for this: https://github.com/status-im/nimbus-eth2/issues/2146

arnetheduck commented 3 years ago

Covered by metrics (https://github.com/status-im/nim-libp2p/blob/unstable/libp2p/protocols/pubsub/gossipsub/behavior.nim#L25:L25) and logging