status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
543 stars 233 forks source link

Cannot compile Nimbus 1.0.7: make: *** No rule to make target 'beacon_node'. Stop. #2295

Closed ZaneCEO closed 3 years ago

ZaneCEO commented 3 years ago

Describe the bug The new version 1.0.7 cannot be compiled. make beacon_node gives this error:

make: *** No rule to make target 'beacon_node'. Stop.

To Reproduce Steps to reproduce the behavior:

On Ubuntu 20.04:

git clone https://github.com/status-im/nimbus-eth2.git
cd nimbus-eth2
make -j4 beacon_node

Additional context In 1.0.6, make worked just fine.

ZaneCEO commented 3 years ago

Ok, I found the issue. The old version had this into the makefile:

# Targets for backwards compatibility
beacon_node: | nimbus_beacon_node
    cp build/nimbus_beacon_node build/beacon_node

It's now removed, so the only working command is make nimbus_beacon_node

Did you guys announced this change anywhere?

kdeme commented 3 years ago

Yes, we forgot to mention this in the release notes initially.

They have been updated to address this: https://github.com/status-im/nimbus-eth2/releases/tag/v1.0.7

Thanks for mentioning this!

ZaneCEO commented 3 years ago

Got it, thanks!