status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
543 stars 233 forks source link

Log improvements #437

Closed mratsim closed 4 years ago

mratsim commented 5 years ago

Looking at the logs we send we can improve those:

It might be good to think deeply about logging during the offsite as it will be the primary tool people will use to interact with Nimbus.

mratsim commented 5 years ago

Another thing is that logging might introduce high overhead by repeatedly reporting the hash_tree_root of the state. I might be helpful to benchmark the cost of SSZ serialization. I don't think we can cache it though as we need a hash as a cache ID anyway.

arnetheduck commented 5 years ago

one thing to note is the log level: INF should be the log level we recommend users to run and thus what we audit for a "sensible" and complete, normalized/minimal output of data that will allow us to meaningfully "replay" scenarios the user encounters

mratsim commented 4 years ago

Closing: the goal of this issue was to improve logging for the interop event. As the codebase mature and the "real" testnet approaches, our logging needs have changed and will be tracked in new issues.