status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
517 stars 222 forks source link

Inconsistent types for address field in logs #5503

Open jakubgs opened 11 months ago

jakubgs commented 11 months ago

Currently our Logstash is generating a LOT of warnings like this:

object mapping for [json.address] tried to parse field [address] as object, but found a concrete value

This happens because the address field is sometimes a string:

{"lvl":"DBG","ts":"2023-10-12 17:37:17.265+00:00","msg":"Timed out or unrequested whoareyou packet","topics":"eth p2p discv5","address":"75.119.130.1:30303"}

And sometimes an object:

{"lvl":"DBG","ts":"2023-10-12 17:44:13.179+00:00","msg":"Sending message to RPC server","topics":"JSONRPC-HTTP-CLIENT","address":{"oResultPrivate":true,"vResultPrivate":{"id":"localhost:8552","scheme":"NonSecure","hostname":"localhost","port":8552,"path":"","query":"","anchor":"","username":"","password":"","addresses":[{"family":"IPv4","address_v4":[127,0,0,1],"port":8552}]}},"msg_len":345,"name":"engine_forkchoiceUpdatedV2"}

Could we please make this consistent?

jakubgs commented 11 months ago

Silenced as well:

Will undo it once this is fixed.