status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

electra attestation updates #6295

Closed arnetheduck closed 4 months ago

arnetheduck commented 4 months ago

In Electra, we have two attestation formats: on-chain and on-network - the former combines all committees of a slot in a single committee bit list.

This PR makes a number of cleanups to move towards fixing this - attestation packing however still needs to be fixed as it currently creates attestations with a single committee only which is very inefficient.

github-actions[bot] commented 4 months ago

Unit Test Results

         9 files  ±0    1 322 suites  +3   36m 57s :stopwatch: + 3m 5s   4 983 tests +1    4 635 :heavy_check_mark: +1  348 :zzz: ±0  0 :x: ±0  20 805 runs  +3  20 401 :heavy_check_mark: +3  404 :zzz: ±0  0 :x: ±0 

Results for commit 3d05f899. ± Comparison against base commit 826bf4c3.

:recycle: This comment has been updated with latest results.