search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

VC: Deprecate fallback path to produceBlockV2, use produceBlockV3 always. #6300

Closed cheatfate closed 4 months ago

github-actions[bot] commented 4 months ago

Unit Test Results

         9 files  ±0    1 325 suites  ±0   32m 50s :stopwatch: +41s   4 984 tests ±0    4 636 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 808 runs  ±0  20 404 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit 0a24f117. ± Comparison against base commit d7c5bc03.

tersec commented 4 months ago

In general, seems like a good idea if the BNs support it -- which is likely, as produceBlockV3 is standard in spec, but not yet certainly known.

Not yet confirmed CLs are mainly Teku and Prysm, with Prysm being a bit ambiguous because of their gRPC focus and generally not-widespread interoperability in the most recent EF VC/BN tests anyway.

tersec commented 4 months ago

https://github.com/status-im/nimbus-eth2/pull/5644#issuecomment-1843025498

Teku's fine.

Going off https://github.com/kurtosis-tech/ethereum-package?tab=readme-ov-file#beacon-node--validator-client-compatibility Prysm's BN does support other VCs in general (the default incompatibility is from the VC side), so that should be verified too.

tersec commented 4 months ago

Prysm confirmed