status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

align field name across `SomeSig` #6348

Closed etan-status closed 3 months ago

etan-status commented 3 months ago

ValidatorSig uses blob but TrustedSig uses data, aligning the names reduces code duplication and improves clarity. It also simplifies StableContainer compatibility checks.

github-actions[bot] commented 3 months ago

Unit Test Results

         9 files  ±0    1 325 suites  ±0   34m 27s :stopwatch: + 2m 29s   4 986 tests ±0    4 638 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 814 runs  ±0  20 410 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit 63469162. ± Comparison against base commit 3d65bdcb.