status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

remove Bellatrix EL syncing support from light client #6352

Closed etan-status closed 3 months ago

etan-status commented 3 months ago

Bellatrix light client data does not contain the EL block hash, so we had to follow blocks gossip to learn the EL block_hash of such blocks. Now that Bellatrix is obsolete, we can simplify EL syncing logic under light client scenarios. Bellatrix light client data can still be used to advance the light client sync itself, but will no longer result in engine_forkchoiceUpdated calls until the sync reaches Capella. This also frees up some memory as we no longer have to retain blocks.

github-actions[bot] commented 3 months ago

Unit Test Results

         9 files  ±0    1 325 suites  ±0   24m 48s :stopwatch: - 4m 6s   4 986 tests ±0    4 638 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 814 runs  ±0  20 410 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit ff01f6e5. ± Comparison against base commit 81e6fe50.