search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

chore: fix some comments #6374

Open renshuncui opened 3 months ago

tersec commented 3 months ago

Needs to target the unstable branch

renshuncui commented 2 months ago

Needs to target the unstable branch

Thanks. Modified

tersec commented 2 months ago

One of the files you modified also therefore needs a copyright year update, which is otherwise causing the linting CI check to fail:

Run excluded_files="config.yaml"
The following files do not have an up-to-date copyright year:
- scripts/signers/web3signer.sh
Error: Process completed with exit code 2.

https://github.com/status-im/nimbus-eth2/blob/fd4398d4c5ab5583059f877b6f96cb70d8026aa9/scripts/signers/web3signer.sh#L3 should read

# Copyright (c) 2023-2024 Status Research & Development GmbH.
github-actions[bot] commented 2 months ago

Unit Test Results

         9 files  ±0    1 334 suites  ±0   29m 35s :stopwatch: -12s   4 999 tests ±0    4 651 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 877 runs  ±0  20 473 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit 8af47432. ± Comparison against base commit fd4398d4.