status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

ensure passing unsigned integer to `rlp.encode` #6397

Closed etan-status closed 2 months ago

etan-status commented 2 months ago

RLP encoding is not defined for signed integers. Make sure to use unsigned integers when encoding RLP for EL block hash computation.

github-actions[bot] commented 2 months ago

Unit Test Results

         9 files  ±0    1 334 suites  ±0   26m 50s :stopwatch: - 1m 13s   4 999 tests ±0    4 651 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 877 runs  ±0  20 473 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit 535483f1. ± Comparison against base commit 8c67a265.