status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
543 stars 233 forks source link

validate EL block hash when running consensus block tests #6406

Open etan-status opened 4 months ago

etan-status commented 4 months ago

We currently don't have an easy way to test EL block hash computation. As the EL block hash in consensus-spec-tests is computed correctly, update the test runners that load block from test files to also verify the EL block hash. This increases missing test coverage.

Requires https://github.com/ethereum/consensus-specs/pull/3829

github-actions[bot] commented 4 months ago

Unit Test Results

0 files   -        12  0 suites   - 1 810   0s :stopwatch: - 1h 0m 10s 0 tests  -   5 227  0 :heavy_check_mark:  -   4 879  0 :zzz:  - 348  0 :x: ±0  0 runs   - 29 057  0 :heavy_check_mark:  - 28 605  0 :zzz:  - 452  0 :x: ±0 

Results for commit 57b312ca. ± Comparison against base commit 40f2acc9.

:recycle: This comment has been updated with latest results.