status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
543 stars 233 forks source link

validate EL block hash in Electra when no EL is connected #6407

Closed etan-status closed 4 months ago

etan-status commented 4 months ago

When no EL is connected, it is still required to validate the block hash of ExecutionPayload to prevent attacks that trick us into attesting to a circular chain with invalid in-between block hashes. This is already done through Deneb but was still missing in Electra to be rectified now.

github-actions[bot] commented 4 months ago

Unit Test Results

         9 files  ±0    1 334 suites  ±0   27m 48s :stopwatch: + 1m 18s   4 999 tests ±0    4 651 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 877 runs  ±0  20 473 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit efb94ed5. ± Comparison against base commit c59bb719.