search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

bump nimcrypto to `71bca15508e2c0548f32b42a69bcfb1ccd9ab9ff` #6430

Closed etan-status closed 2 months ago

etan-status commented 2 months ago
tersec commented 2 months ago

Slightly on the risky side this late (a few days at most) before the next release branches.

cheatfate commented 2 months ago

keccak is not used anywhere in nimbus-eth2 why it is needed?

etan-status commented 2 months ago

It's used when syncing optimistically without an attached EL, or when EL is temporarily unreachable due to maintenance.

At the very least, some component must validate that the execution_payload.block_hash is correct. for that, keccak is needed. If EL is connected, it can be queried. Otherwise, CL has to do it themselves or wait until EL is back online.

etan-status commented 2 months ago

https://github.com/status-im/nimbus-eth2/blob/377698d65abe0802a4520440c93d431a09ac60ab/beacon_chain/spec/helpers.nim#L607