status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

pause deployment of long-range sync option default #6436

Closed tersec closed 2 months ago

tersec commented 2 months ago

Inspired by https://github.com/status-im/nimbus-eth2/issues/6433

They were offline long enough they're outside the WSP.

The change has (correctly, as far as it goes) prevented them from restarting, because the "light client sync" part is still to come. Once it does, they'd catch up automatically with the new setting.

The tradeoff is, people who change the setting to avoid that in the transition period often/likely won't bother changing it back, so for the sake of increasing adoption of the setting in the medium-to-long-term, delay deployment for the next release.

This is not a revert -- all the code stays in place, it's fine, just a default change and therefore leaving the option not-yet-documented. It hasn't been in any releases yet.

github-actions[bot] commented 2 months ago

Unit Test Results

         9 files  ±0    1 334 suites  ±0   29m 20s :stopwatch: - 2m 3s   4 999 tests ±0    4 651 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 877 runs  ±0  20 473 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit f0b7b96e. ± Comparison against base commit 377698d6.