search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

fix some UnusedImport warnings #6448

Closed tersec closed 2 months ago

tersec commented 2 months ago 
2024-07-25T02:05:59.6045279Z ......................................................................................................................../github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/eth2_agents.nim(12, 30) Warning: imported and not used: 'multicodec' [UnusedImport]
2024-07-25T02:05:59.6047673Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/eth2_agents.nim(12, 42) Warning: imported and not used: 'peerstore' [UnusedImport]
2024-07-25T02:05:59.6049952Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/networking/eth2_agents.nim(12, 16) Warning: imported and not used: 'multiaddress' [UnusedImport]
tersec commented 2 months ago

jenkins/nimbus-eth2/linux/x86_64/nix CI failure unrelated to PR, e.g., https://github.com/status-im/nimbus-eth2/pull/6446

github-actions[bot] commented 2 months ago

Unit Test Results

         9 files  ±0    1 334 suites  ±0   29m 31s :stopwatch: -15s   5 000 tests ±0    4 652 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 880 runs  ±0  20 476 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit ef77e79d. ± Comparison against base commit 15cca5f9.

jakubgs commented 2 months ago

The jenkins/nimbus-eth2/linux/x86_64/nix failure is because of changed hash, because you updated Nim, but not the hashes for the additional repos that need to be checked out: https://github.com/status-im/nimbus-eth2/blob/dc27384ae410c63de96d0968c33ae8860bf9b2d7/nix/default.nix#L57-L67

Fixed in:

Please review https://github.com/status-im/nimbus-eth2/pull/6446.