status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

remove unsued `lcDataForkAtEpoch` helper #6449

Closed etan-status closed 2 months ago

etan-status commented 2 months ago

lcDataForkAtEpoch(.) is not used anywhere and can be removed. lcDataForkAtConsensusFork(consensusForkAtEpoch(.)) saves same purpose.

tersec commented 2 months ago

https://github.com/status-im/nimbus-eth2/pull/6446 fixes the jenkins/nimbus-eth2/linux/x86_64/nix failure, which is unrelated to this PR

github-actions[bot] commented 2 months ago

Unit Test Results

         9 files  ±0    1 334 suites  ±0   29m 19s :stopwatch: - 1m 43s   5 000 tests ±0    4 652 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 880 runs  ±0  20 476 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit fa89c19d. ± Comparison against base commit 8c621b9a.