status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

Revert "bump nim-nat-traversal to `459fc4968799bde97592137f42d93e5069f06e73`" #6466

Closed tersec closed 2 months ago

tersec commented 2 months ago

Reverts status-im/nimbus-eth2#6461

Starting 2 days, ago, the first nightly after it went in at https://github.com/status-im/nimbus-eth2/actions/runs/10120946357/job/27991306484 showed:

undef: ___isOSVersionAtLeast
Undefined symbols for architecture x86_64:
  "___isOSVersionAtLeast", referenced from:
      _upnp_gettimeofday in libminiupnpc.a(minissdpc.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [nimcache/release/nimbus_beacon_node/nimbus_beacon_node.makefile:3292: build] Error 1

Which is due to https://github.com/status-im/nim-nat-traversal/pull/24 and in turn https://github.com/status-im/miniupnp/commit/1d38b377326dbeacb4f21f5fd6afe9d0fb89178a which introduces the __builtin_available call, which triggers usage of ___isOSVersionAtLeast.

This should be fixed at the build system level, but for now, revert this change to get nightlies building again.

github-actions[bot] commented 2 months ago

Unit Test Results

         9 files  ±0    1 334 suites  ±0   29m 9s :stopwatch: -34s   5 000 tests ±0    4 652 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 880 runs  ±0  20 476 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit bd6dedda. ± Comparison against base commit 9e75136d.

etan-status commented 1 month ago