search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

Revert "stop testing broken upstream version-2-0" #6506

Closed arnetheduck closed 1 month ago

arnetheduck commented 1 month ago

Reverts status-im/nimbus-eth2#6499

arnetheduck commented 1 month ago

https://github.com/nim-lang/Nim/issues/24002

github-actions[bot] commented 1 month ago

Unit Test Results

         9 files  ±0    1 334 suites  ±0   34m 13s :stopwatch: + 2m 28s   5 064 tests ±0    4 716 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  20 991 runs  ±0  20 587 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit 412dd6a6. ± Comparison against base commit 77c36b3c.

tersec commented 1 month ago

No objections to merging this once the issue is resolved

arnetheduck commented 1 month ago

so per the comments in the PR, this is actually a latent bug in our code exposed by additional strictness - ie the template never worked as intended basically, and prints None in the logs.

tersec commented 1 month ago

In which case, fixing that code in nimbus-eth2 works also

arnetheduck commented 1 month ago

seems to work