search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

Add GetAggregateAttestation V2 endpoint version #6511

Closed pedromiguelmiranda closed 3 weeks ago

pedromiguelmiranda commented 1 month ago

Added new version (v2) of GetAggregateAttestation endpoint to support EIP-7549. spec: https://github.com/ethereum/beacon-APIs/pull/447

github-actions[bot] commented 1 month ago

Unit Test Results

         9 files  ±0    1 343 suites  ±0   47m 43s :stopwatch: +33s   5 141 tests +1    4 793 :heavy_check_mark: +1  348 :zzz: ±0  0 :x: ±0  21 195 runs  +3  20 791 :heavy_check_mark: +3  404 :zzz: ±0  0 :x: ±0 

Results for commit a878da2a. ± Comparison against base commit f9a4add8.

:recycle: This comment has been updated with latest results.

tersec commented 3 weeks ago

https://github.com/status-im/nimbus-eth2/actions/runs/10667055348/job/29568268145

2024-09-02T14:16:25.3542317Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/validator_client/attestation_service.nim(248, 63) template/generic instantiation of `async` from here
2024-09-02T14:16:25.3544530Z /github-runner/workspace/nimbus-eth2/nimbus-eth2/beacon_chain/validator_client/attestation_service.nim(283, 17) Error: type mismatch
2024-09-02T14:16:25.3546172Z Expression: getAggregatedAttestation(vc, slot, attestationRoot, committeeIndex, Best)
2024-09-02T14:16:25.3547078Z   [1] vc: ValidatorClientRef
2024-09-02T14:16:25.3547523Z   [2] slot: Slot
2024-09-02T14:16:25.3547931Z   [3] attestationRoot: Digest
2024-09-02T14:16:25.3548412Z   [4] committeeIndex: uint64
2024-09-02T14:16:25.3656072Z   [5] Best: ApiStrategyKind
2024-09-02T14:16:25.3656467Z 
2024-09-02T14:16:25.3656729Z Expected one of (first mismatch at [position]):
2024-09-02T14:16:25.3657569Z [3] proc getAggregatedAttestation(vc: ValidatorClientRef; slot: Slot;
2024-09-02T14:16:25.3658498Z                               committee_index: CommitteeIndex; root: Eth2Digest;
2024-09-02T14:16:25.3659324Z                               strategy: ApiStrategyKind): Future[Attestation]
2024-09-02T14:16:25.3659828Z 
2024-09-02T14:16:25.5278872Z make: *** [Makefile:447: nimbus_validator_client] Error 1
2024-09-02T14:16:25.5279590Z make: *** Waiting for unfinished jobs....

running make nimbus_validator_client locally can find this too