etan-status
commented
1 month ago I think it's good to have, as an improvement over genesis sync when --external-beacon-api-url is not provided (pure decentralized mode). By default this is only used on Holesky and when syncing from outdated database, so the risk of accidental interference with validator duties is minimal.
The latest changes make it track the finalized checkpoint, meaning no reorgs are expected, so the branch being backfilled is expected to remain available during the sync.
One remaining item could be file system performance when lots of blocks are downloaded. Maybe it needs subdirectories if millions of blocks are queued up, or an incremental sync that only does 1 sync committee period at a time. But such changes could be introduced later if needed.
Unit Test Results
12 files ± 0 1 814 suites +4 53m 34s :stopwatch: -50s 5 232 tests + 5 4 884 :heavy_check_mark: + 5 348 :zzz: ±0 0 :x: ±0 29 077 runs +20 28 625 :heavy_check_mark: +20 452 :zzz: ±0 0 :x: ±0
Results for commit fe6452e7. ± Comparison against base commit 250a80eb.
:recycle: This comment has been updated with latest results.