search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
543 stars 233 forks source link

Rid result from `get_custody_column_subnets` #6543

Closed agnxsh closed 2 months ago

agnxsh commented 2 months ago

As discussed with @tersec , the scenario where custody_subnet_count would exceed DATA_COLUMN_SIDECAR_SUBNET_COUNT, would hardly appear, regardless the check's mention in specs: https://github.com/ethereum/consensus-specs/blob/dev/specs/_features/eip7594/das-core.md#get_custody_columns

The highest custody_subnet_count can be ever attainable in Nimbus' prod branch would be = to DATA_COLUMN_SIDECAR_SUBNET_COUNT, via the --subscribe-all-subnets flag, and no way else.

Hence, the usage of result and it's corresponding get was becoming unintentionally useless.

The check and potentially the result, would however be useful in the devnet branches, as it would get us a clear indication of data column reconstruction, it's timings and CPU utilizations.

github-actions[bot] commented 2 months ago

Unit Test Results

         9 files  ±0    1 343 suites  ±0   47m 52s :stopwatch: - 2m 9s   5 141 tests ±0    4 793 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  21 195 runs  ±0  20 791 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit 9cc54ff9. ± Comparison against base commit 1503c7df.