search

status-im / nimbus-eth2

Nim implementation of the Ethereum Beacon Chain
https://nimbus.guide
Other
523 stars 227 forks source link

Electra REST forked BeaconBlockBody reading support #6551

Closed tersec closed 1 week ago

tersec commented 1 week ago

Won't be merged in September's release cycle, because it affects Deneb REST block reading and can't be readily isolated into future-forks-only codepaths aside from not very usefully disabling it by default.

It's not yet complete, either, because of the requests in ExecutionPayload, but those might be changing soon, so won't address them yet.

tersec commented 1 week ago

version-2-0 CI failure is unrelated: https://github.com/nim-lang/Nim/issues/24104

github-actions[bot] commented 1 week ago

Unit Test Results

         9 files  ±0    1 346 suites  ±0   49m 48s :stopwatch: + 1m 42s   5 142 tests ±0    4 794 :heavy_check_mark: ±0  348 :zzz: ±0  0 :x: ±0  21 198 runs  ±0  20 794 :heavy_check_mark: ±0  404 :zzz: ±0  0 :x: ±0 

Results for commit 0d9832d3. ± Comparison against base commit 72b5c2bd.

tersec commented 1 week ago

https://github.com/status-im/nimbus-eth2/pull/6552 is better