search

status-im / open-bounty

Enable communities to distribute funds to push their cause forward.
https://openbounty.status.im/
GNU Affero General Public License v3.0
118 stars 36 forks source link

After deleting GH repo bounties are still displayed in 'Open bounties' list #356

Open churik opened 6 years ago

churik commented 6 years ago

Description

Type: Bug

Summary: bounties from deleted repo are displayed on 'Open bounties', at attempt to open it - user is redirected to 404 page

Expected behavior

no bounties from deleted repo are shown

Actual behavior

bounties from deleted repo are still in 'Open bounties' list

Reproduction

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo;

Additional Information

Video: http://take.ms/Sb8jH OS: Mac OS High Sierra Browser: Chrome 64

rcullito commented 6 years ago

This seems like it could be handled via a webhook that watches for a deleted repository event and then deletes issues and pull requests associated with that repo id.

arash009 commented 6 years ago

Sounds like we need another 'state' that bounties could be in. If this happens, or the GH issue is closed/deleted, the bounty contract is still live, so these bounties should go into a "inactive" state for the bounty issuer to revoke.

rcullito commented 6 years ago

That's a good point that a manual action needs to be taken as well. Seems like there are actually quite a few use cases where bounties need to be revoked. (to all of your points in the last standup)