Iterate through return value of extract-issue-number instead of always picking first

status-im / open-bounty

Enable communities to distribute funds to push their cause forward.

https://openbounty.status.im/

GNU Affero General Public License v3.0

118 stars 36 forks source link

Iterate through return value of extract-issue-number instead of always picking first #383

Closed vitvly closed 6 years ago

vitvly commented 6 years ago

Fixes #382

churik commented 6 years ago

Environments

Ethereum wallet used: MetaMask
Browser: Chrome
Operating System: macOS High Sierra 10.13.3

Tested functionality

New claims are detected on bounty regardless of keywords closing other issues (not bounties or no-existing)
When PR contains several fixes for bounty issues - only first is detected (known - https://github.com/status-im/open-bounty/issues/358)

martinklepsch commented 6 years ago

Could we easily fix https://github.com/status-im/open-bounty/issues/358 by iterating over the issues for which issues/get-issue returns something?

(doseq [i (->> (extract-issue-number owner repo pr-body pr-title)
               (map #(issues/get-issue repo-id %1))
               (remove nil?))]
  (handle-issue ,,,))

vitvly commented 6 years ago

@martinklepsch great idea, followed your suggestion: https://github.com/status-im/open-bounty/pull/391