fix padding for dropdown claims

status-im / open-bounty

Enable communities to distribute funds to push their cause forward.

https://openbounty.status.im/

GNU Affero General Public License v3.0

118 stars 36 forks source link

fix padding for dropdown claims #420

Closed rcullito closed 6 years ago

rcullito commented 6 years ago

About

The grey box containing claims info will run to the entire width of the column.

Before

After

Additional Considerations

[x] make sure padding is correct in case of "no matching data found"
[x] Do we still need the activities page in light of #359 being merged? (question has been posed. if we decide to remove that page then it should happen in a separate PR from this one)

rcullito commented 6 years ago

Testing

@churik In terms of testing steps I was really trying to ensure that the padding on the other elements beyond just the claims dropdown was not affected beyond what was necessary.

Affected elements include: a.) the header that says "Bounties" b.) the filters c.) the row that displays the total count and another sorting option

Let me know if I can clarify any other part of this. The motivation for the change came from some comments in slack and I think was also listed in the initial design requirement. 🗿

churik commented 6 years ago

@rcullito It also affects to pagination; in the red rectangle - how it looks in PR, in green - how it is now in develop. Expected: it should look like in develop branch monosnap screenshot tool 2018-04-17 14-29-32

rcullito commented 6 years ago

@churik great catch, thanks! I will give it another pass.

rcullito commented 6 years ago

navigation has been addressed @churik 👍 thanks again.

churik commented 6 years ago

Environments

Chrome, Firefox 58, Safari 11 ( macOS High Sierra 10.13.3), Safari (IOS 11.3, IPhone 7)

Operating System: macOS High Sierra 10.13.3

Tested functionality

General view of bounty with several claims, pagination, Manage Payouts, Update Payment Details screens
header and filters
Applying filters