fix #432 load more activities

status-im / open-bounty

Enable communities to distribute funds to push their cause forward.

https://openbounty.status.im/

GNU Affero General Public License v3.0

118 stars 36 forks source link

fix #432 load more activities #436

Closed martinklepsch closed 6 years ago

martinklepsch commented 6 years ago

Fixes #432

Loading to few activities can cause claims not being displayed as claims and bounties are loaded via separate XHR requests. This change implements a quick fix around that making old activities show up.

Long term we should move claims into the response of /api/open-bounties so that they always are available for bounties shown in the UI.

This is also somewhat related to better API pagination as described in https://github.com/status-im/open-bounty/issues/250

asemiankevich commented 6 years ago

@martinklepsch hey, i have noticed that 1 old claim is still not being displayed. It is on TEST env, page 4

would you mind to take a look?

martinklepsch commented 6 years ago

@asemiankevich the fix proposed in this PR only makes the problem less apparent for the majority of users but doesn't fix it entirely as you discovered in your testing.

I will merge this for now, a more holistic solution is still pending.