Update comment only if hash changes 385

vitvly commented 6 years ago

Fixes #385

Status: WIP

churik commented 6 years ago

@siphiuel

After deployment of this PR:

1) pictures are not displayed in "Activity" and "Bounties" page

GET https://testing.openbounty.status.im/api/user/bounties Status: 500 Responce: ["^ ",":type","unknown-exception","~:class","clojure.lang.ExceptionInfo"]

app.js?v=6ad3d13:999 GET https://testing.openbounty.status.im/api/user/bounties 500 ()
k.send @ app.js?v=6ad3d13:999
k.ff @ app.js?v=6ad3d13:1010
RK @ app.js?v=6ad3d13:867
gP @ app.js?v=6ad3d13:1010
hP.l @ app.js?v=6ad3d13:1011
hP @ app.js?v=6ad3d13:1011
KU @ app.js?v=6ad3d13:1225
(anonymous) @ app.js?v=6ad3d13:819
TI @ app.js?v=6ad3d13:811
dJ @ app.js?v=6ad3d13:812
kJ @ app.js?v=6ad3d13:817
iJ @ app.js?v=6ad3d13:813
(anonymous) @ app.js?v=6ad3d13:814
jJ @ app.js?v=6ad3d13:817
(anonymous) @ app.js?v=6ad3d13:813
b.port1.onmessage @ app.js?v=6ad3d13:808

2) seems that new `develop` should be merged into PR (no "Manage payout" tab)

manpay

vitvly commented 6 years ago

Restored pictures.
Branch was already up-to-date, Manage Payouts appears once a GitHub app is added to a repo owned by the user currently logged in.

churik commented 6 years ago

3. QR codes are not displayed in GH comments

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo;

create issue with bounty
open it on GitHub

Actual result:

QR code image is broken qrd

Expected result:

QR code is displayed

OS: Mac OS High Sierra Browser: Chrome 64

churik commented 6 years ago

4. Cannot deploy several bounties in a row

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo;

create several issues (5 in my case)
assign then 'bounty' label
wait for contract deployment for all issues

Actual result:

the contract is deployed only for first bounty, other deployments failed

2018-05-18 13:28:04,747 [XNIO-1 task-5] INFO  commiteth.bounties - issue 324410252: Deploying contract to 0xcf2272205cc0cf96cfbb9dd740bd681d1e86901e 
2018-05-18 13:28:04,860 [XNIO-1 task-5] ERROR commiteth.bounties - issue 324410252: deploy-contract exception 
2018-05-18 13:28:40,819 [async-thread-macro-2] INFO  commiteth.scheduler - issue 324410252: Trying to re-deploy failed bounty contract deployment

Expected result:

contracts are deploed for all issues

OS: Mac OS High Sierra Browser: Chrome 64 Log: log1.log

churik commented 6 years ago

5. Balances are not updated after funding a bounty

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo;

create 1 issue with bounty
fund it
wait until transaction will be completed
wait for 10 min

Actual result:

contract balance will be updated

Expected result:

contract balance is 0

OS: Mac OS High Sierra Browser: Chrome 64 Issue: https://github.com/TestingEnvENV/TestEnvAtt5_1/issues/266 Log events:

2018-05-18 13:15:22,729 [XNIO-1 task-5] INFO  commiteth.bounties - issue 324406188: Deploying contract to 0xcf2272205cc0cf96cfbb9dd740bd681d1e86901e 
2018-05-18 13:15:23,653 [XNIO-1 task-5] INFO  commiteth.bounties - issue 324406188: Contract deployed, transaction-hash: 0x1896a11c82abcae368a0170c02e4e436972b4278e2ea1407052c21caddc1ed1b 
2018-05-18 13:15:40,699 [async-thread-macro-1] INFO  commiteth.scheduler - issue 324406188: pending deployment: 0x1896a11c82abcae368a0170c02e4e436972b4278e2ea1407052c21caddc1ed1b 
2018-05-18 13:16:40,655 [async-thread-macro-2] INFO  commiteth.scheduler - issue 324406188: pending deployment: 0x1896a11c82abcae368a0170c02e4e436972b4278e2ea1407052c21caddc1ed1b 
2018-05-18 13:16:40,789 [async-thread-macro-2] INFO  commiteth.scheduler - issue 324406188: update-issue-contract-address: tx receipt: {:logsBloom "0x00000000000000000000000004000000000000000008000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000400000000000000000000000002000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080004000000000000000000000000000000400000000000000000000000000000000000000000000000000000000800", :contractAddress nil, :transactionHash "0x1896a11c82abcae368a0170c02e4e436972b4278e2ea1407052c21caddc1ed1b", :blockHash "0xc68ef788c3cc17a8c352b213409f60c4f49c9006c839955fe9f33ae190ff1d10", :logs [{:address "0x3b9a3c062bdb640b5039c0ccda4157737d732f95", :transactionHash "0x1896a11c82abcae368a0170c02e4e436972b4278e2ea1407052c21caddc1ed1b", :blockHash "0xc68ef788c3cc17a8c352b213409f60c4f49c9006c839955fe9f33ae190ff1d10", :transactionIndex "0x1", :topics ["0x96b5b9b8a7193304150caccf9b80d150675fa3d6af57761d8d8ef1d6f9a1a909" "0x00000000000000000000000089bb5a1880608fe606f6d2c3dc30c3624f3429fc"], :blockNumber "0x31bb65", :logIndex "0x0", :removed false, :data "0x000000000000000000000000dde2e4fb0f35723bf5b6c3f932271f8687f3b0a9"}], :transactionIndex "0x1", :blockNumber "0x31bb65", :status "0x1", :from "0x89bb5a1880608fe606f6d2c3dc30c3624f3429fc", :gasUsed "0xc758e", :cumulativeGasUsed "0xcdeb1", :to "0x3b9a3c062bdb640b5039c0ccda4157737d732f95"} 
2018-05-18 13:25:41,070 [async-thread-macro-2] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 324406188 
2018-05-18 13:35:40,832 [async-thread-macro-2] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 324406188 
2018-05-18 13:45:40,810 [async-thread-macro-2] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 324406188 
2018-05-18 13:55:40,829 [async-thread-macro-6] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 324406188

churik commented 6 years ago

@siphiuel To summarize:

[x] ~~pictures are not displayed in "Activity" and "Bounties" page~~
[x] ~~seems that new develop should be merged into PR (no "Manage payout" tab)~~
[x] ~~QR codes are not displayed in GH comments~~
[x] ~~Cannot deploy several bounties in a row~~
[x] ~~Balances are not updated after funding a bounty~~ ~~From @churik: https://github.com/status-im/open-bounty/pull/447#issuecomment-391989637~~
[x] ~~Balance in GH comment can be displayed in exponential format~~
[x] ~~Cannot claim a bounty~~
[x] ~~Revocation freezes in state "Pending user to save ETH address" and with winner "Null"~~
[x] ~~GH comment is not updated when BHunter has no ETH address~~
[x] ~~Cannot set payment address~~
[x] ~~Reloading page leads to disabling "Disguise myself from the top hunters and activity lists."~~
[x] ~~Unable to complete signup - no redirect after authorizing GH app~~

vitvly commented 6 years ago

Fixed the following issues:

QR codes are not displayed in GH comments
Cannot deploy several bounties in a row
Balances are not updated after funding a bounty

churik commented 6 years ago

6. Balance in GH comment can be displayed in exponential format

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo;

create 1 issue with bounty
fund it with a small amount of ETH (i.e., 0.0003 ETH)
wait until transaction is completed
check GH bot comment

Actual result:

Balance is displayed in exponential format default

Expected result:

double format (i.e., 0.0003 ETH)

OS: Mac OS High Sierra Browser: Chrome 64 Issue: https://github.com/TestingEnvENV/toTestWebHook/issues/1

churik commented 6 years ago

7. Cannot claim a bounty

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo;

create 1 issue with bounty
create a claim to fix it ("Fix #issue" in PR comment)

Actual result:

No open claim

Expected result:

New claim submitted

OS: Mac OS High Sierra Browser: Chrome 64 Issue: https://github.com/TestingEnvENV/TestEnvAtt5_1/issues/290 Note: if PR is merged, bounty stays in "Unclaimed" section, but disappears from general "Bounties" list

vitvly commented 6 years ago

Fixed #6 and #7

churik commented 6 years ago

8. Revocation freezes in state "Pending user to save ETH address" and with winner "Null"

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo;

create 1 issue with bounty
fund it
log in to https://testing.openbounty.status.im/
navigate to "Bounty" and click "Revoke"
wait until bot transaction will be completed

Actual result:

bounty is freezing in state "Refund Pending" rev_1 rev_2

Expected result:

New transaction in MetaMask for confirmation

OS: Mac OS High Sierra Browser: Chrome 64 Issue: https://github.com/TestingEnvENV/TestEnvAtt5_1/issues/299 Issue is not reproducible on Staging, so it is provided by current PR. Log: Log

churik commented 6 years ago

9. GH comment is not updated when BHunter has no ETH address

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo; BHunter hasn't set ETH address

create 1 issue with bounty
fund it
create PR to fix it
merge PR
open "Manage payouts"
wait until "payment address is pending. You will be able to confirm the payment once the address is provided." appeared ("To Confirm payment" tab)
wait 5 mins more
check GH comment in bounty

Actual result:

Comment is not updated pend

Expected result:

"Pending user to save ETH address", winner is set

OS: Mac OS High Sierra Browser: Chrome 64 Log: log.txt

churik commented 6 years ago

10. Cannot set payment address

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo; BHunter hasn't set ETH address

open "My Payment Details"
insert valid payment address
click on "Update"

Actual result:

err Request: https://testing.openbounty.status.im/api/user POST ["^ ","~:address","0x53647A35eA1Dc3bAC2d46aC27397B590f8003823","~:is_hidden_in_hunters",null] Response: 400 ["^ ","~:errors",["^ ","~:is_hidden_in_hunters","(not (instance? java.lang.Boolean nil))"]]

Expected result:

OS: Mac OS High Sierra Browser: Chrome 64

churik commented 6 years ago

11. Reloading page leads to disabling "Disguise myself from the top hunters and activity lists."

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo; BHunter hasn't set ETH address

open "My Payment Details"
enable "Disguise myself from the top hunters and activity lists."
click on "Update"
reload page

Actual result:

"Disguise myself from the top hunters and activity lists." is displayed as disabled

Expected result:

"Disguise myself from the top hunters and activity lists." is displayed as enabled OS: Mac OS High Sierra Browser: Chrome 64 Video: http://take.ms/KgEKp

churik commented 6 years ago

12. Unable to complete signup - no redirect after authorizing GH app

Steps: Requirements: GH account is whitelisted, but not signed up in SOB

click on Log In
enter GH credentials
authorize application

Actual result:

User not logged in; when you click on "LOG IN" - for user nothing happens, in log:

2018-05-23 12:24:47,898 [XNIO-1 task-10] INFO  commiteth.routes.redirect - access-token: 5dda247055c803638bbf7a7fe478e4b077561799 
2018-05-23 12:24:51,340 [XNIO-1 task-11] INFO  commiteth.routes.redirect - access-token: f3cb6089ddc49497025f4fb0899423a05f6191cd 
2018-05-23 12:24:55,493 [XNIO-1 task-2] INFO  commiteth.routes.redirect - access-token: cfa515ab27a3d50f452fc07137314d95ce1ddf6e

Expected result:

User is logged in

OS: Mac OS High Sierra Browser: Chrome 64 Video: http://take.ms/f1SHQ

Monosnap screenshot tool
File "screencast 2018-05-23 15-18-41.mp4"
Monosnap — the best tool to take & share your screenshots.

churik commented 6 years ago

Balances of bounties aren't updated with tokens. Issue https://github.com/status-im/open-bounty/pull/447#issuecomment-390246788 is reproducible when you add STT to bounty. Not reproducible in develop. Issue example: https://github.com/TestingEnvENV/TestEnvAtt5_1/issues/302 Log:

2018-05-25 08:06:03,497 [XNIO-1 task-9] INFO  commiteth.bounties - issue 326421008: Deploying contract to 0xcf2272205cc0cf96cfbb9dd740bd681d1e86901e 
2018-05-25 08:06:03,957 [XNIO-1 task-9] INFO  commiteth.bounties - issue 326421008: Contract deployed, transaction-hash: 0x19e95f9d0f8a05db0519fa8117694fe63508049f97bf23366c7b61bb80ebf526 
2018-05-25 08:06:50,870 [async-thread-macro-93] INFO  commiteth.scheduler - issue 326421008: pending deployment: 0x19e95f9d0f8a05db0519fa8117694fe63508049f97bf23366c7b61bb80ebf526 
2018-05-25 08:06:50,968 [async-thread-macro-93] INFO  commiteth.scheduler - issue 326421008: update-issue-contract-address: tx receipt: {:logsBloom "0x00000000000000000000000004000000000000000008000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000400000000000000000000000002000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080004000000000000000000000000000000400000000000000000000000000000000000000000000000000000000800", :contractAddress nil, :transactionHash "0x19e95f9d0f8a05db0519fa8117694fe63508049f97bf23366c7b61bb80ebf526", :blockHash "0xf8184d60dc1bf96a2585bf2849cf787377a522b046b51b3a2606fdeb99d812ca", :logs [{:address "0x3b9a3c062bdb640b5039c0ccda4157737d732f95", :transactionHash "0x19e95f9d0f8a05db0519fa8117694fe63508049f97bf23366c7b61bb80ebf526", :blockHash "0xf8184d60dc1bf96a2585bf2849cf787377a522b046b51b3a2606fdeb99d812ca", :transactionIndex "0x2", :topics ["0x96b5b9b8a7193304150caccf9b80d150675fa3d6af57761d8d8ef1d6f9a1a909" "0x00000000000000000000000089bb5a1880608fe606f6d2c3dc30c3624f3429fc"], :blockNumber "0x326cf9", :logIndex "0x1", :removed false, :data "0x000000000000000000000000566d42f27a4551c57b5eaf4df5d9c3374e158d4d"}], :transactionIndex "0x2", :blockNumber "0x326cf9", :status "0x1", :from "0x89bb5a1880608fe606f6d2c3dc30c3624f3429fc", :gasUsed "0xc758e", :cumulativeGasUsed "0x1497a6", :to "0x3b9a3c062bdb640b5039c0ccda4157737d732f95"} 
2018-05-25 08:10:45,762 [async-thread-macro-93] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 326421008 
2018-05-25 08:20:45,872 [async-thread-macro-93] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 326421008 
2018-05-25 08:30:45,852 [async-thread-macro-93] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 326421008 
root@c76244cf5b47:~# cat log/commiteth.log | grep 326421008 --color
2018-05-25 08:06:03,497 [XNIO-1 task-9] INFO  commiteth.bounties - issue 326421008: Deploying contract to 0xcf2272205cc0cf96cfbb9dd740bd681d1e86901e 
2018-05-25 08:06:03,957 [XNIO-1 task-9] INFO  commiteth.bounties - issue 326421008: Contract deployed, transaction-hash: 0x19e95f9d0f8a05db0519fa8117694fe63508049f97bf23366c7b61bb80ebf526 
2018-05-25 08:06:50,870 [async-thread-macro-93] INFO  commiteth.scheduler - issue 326421008: pending deployment: 0x19e95f9d0f8a05db0519fa8117694fe63508049f97bf23366c7b61bb80ebf526 
2018-05-25 08:06:50,968 [async-thread-macro-93] INFO  commiteth.scheduler - issue 326421008: update-issue-contract-address: tx receipt: {:logsBloom "0x00000000000000000000000004000000000000000008000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000400000000000000000000000002000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080004000000000000000000000000000000400000000000000000000000000000000000000000000000000000000800", :contractAddress nil, :transactionHash "0x19e95f9d0f8a05db0519fa8117694fe63508049f97bf23366c7b61bb80ebf526", :blockHash "0xf8184d60dc1bf96a2585bf2849cf787377a522b046b51b3a2606fdeb99d812ca", :logs [{:address "0x3b9a3c062bdb640b5039c0ccda4157737d732f95", :transactionHash "0x19e95f9d0f8a05db0519fa8117694fe63508049f97bf23366c7b61bb80ebf526", :blockHash "0xf8184d60dc1bf96a2585bf2849cf787377a522b046b51b3a2606fdeb99d812ca", :transactionIndex "0x2", :topics ["0x96b5b9b8a7193304150caccf9b80d150675fa3d6af57761d8d8ef1d6f9a1a909" "0x00000000000000000000000089bb5a1880608fe606f6d2c3dc30c3624f3429fc"], :blockNumber "0x326cf9", :logIndex "0x1", :removed false, :data "0x000000000000000000000000566d42f27a4551c57b5eaf4df5d9c3374e158d4d"}], :transactionIndex "0x2", :blockNumber "0x326cf9", :status "0x1", :from "0x89bb5a1880608fe606f6d2c3dc30c3624f3429fc", :gasUsed "0xc758e", :cumulativeGasUsed "0x1497a6", :to "0x3b9a3c062bdb640b5039c0ccda4157737d732f95"} 
2018-05-25 08:10:45,762 [async-thread-macro-93] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 326421008 
2018-05-25 08:20:45,872 [async-thread-macro-93] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 326421008 
2018-05-25 08:30:45,852 [async-thread-macro-93] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 326421008 
2018-05-25 08:40:45,826 [async-thread-macro-93] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 326421008 
2018-05-25 08:50:45,781 [async-thread-macro-93] INFO  commiteth.scheduler - In update-bounty-token-balances for issue 326421008

churik commented 6 years ago

Environments

Ethereum wallet used: MetaMask
Browser: Chrome
Operating System: macOS High Sierra 10.13.3

Tested functionality

On Ropsten:

Creating 10+ bounties in a row;
Signing up new repo for bounty issues;
Create several claims for bounty;
Confirming bounty payments;
Merging PR - closing issue;
Bounty revocation;
Updating payment address;
Bounty in "pending to set ETH address" state
Funding bounties with different currenices/amounts
adding new repo and creating a bounty; On Mainnet:
Create several claims for bounty;
Confirming bounty payments;
Merging PR - closing issue;
Bounty revocation;

status-im / open-bounty