status-im / open-bounty

Enable communities to distribute funds to push their cause forward.
https://openbounty.status.im/
GNU Affero General Public License v3.0
118 stars 36 forks source link

Bounties show zero balance when funded with a token different to SNT, ANT, SWT or ETH #467

Closed 0xjjpa closed 6 years ago

0xjjpa commented 6 years ago

User Story

As an organisation, I want to fund bounty issues with my own ERC-20 tokens, so that my community gets rewarded by helping the product they support.

Description

Type: Bug

Summary: When funding a bounty with an ERC-20 token that isn't SWT, SNT, AWT or ETH, the contract isn't updated and the bounty shows up empty even though it has been funded with some tokens (e.g. MYB).

Expected behavior

The bounty shows up with the right amount of tokens deposited into the bounty. E.g: image

Actual behavior

The bounty shows up zero balance, despite having some tokens being deposited into the bounty. E.g.: image

image

(See bounty and contract address for detailed example).

Reproduction

image

image

Additional Information

0xjjpa commented 6 years ago

@rcullito just mentioned in the chat channel the following likely reason why the token hasn't shown up:

image

Since the MYB token used did a token swap recently, the Parity Registry hasn't been updated.

0xjjpa commented 6 years ago

@rcullito we finally managed to update the token registry with the new token. I think we now only need a cache refresh from your side :blush:

rcullito commented 6 years ago

great news @jjperezaguinaga ! taking a look into it now.

rcullito commented 6 years ago

believe we can close this down for now as we seem to be over the hurdle with the MYB token. from our end, we'll try and make it more explicit in our documentation that new tokens require a ping in riot to let us know.

thanks for bringing up @jjperezaguinaga