search

status-im / pluto

https://status-im.github.io/pluto/
12 stars 3 forks source link

Make pluto accessible to javascript hosts #90

Closed jeluard closed 5 years ago

jeluard commented 5 years ago

Both for web browser and node

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 220.0 DAI (220.0 USD @ $1.0/DAI) attached to it.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 3 months from now. Please review their action plans below:

1) jeremigendron has been approved to start work.

Hello, I have a few questions!

What are the modules you'd like to be exposed when requiring or sourcing the script? Currently, I'm only able to build a script which exposes globally ```js ['goog', 'CLOSURE_IMPORT_SCRIPT', 'CLOSURE_LOAD_FILE_SYNC', 'module', 'exports', 'COMPILED', 'CLOSURE_UNCOMPILED_DEFINES', 'cljs', 'clojure', 'pluto', 'reagent', 'React', 'createReactClass', 'ReactDOM', 're_frame']



Clojure is fun, I'd love to try and figure this out.

Learn more [on the Gitcoin Issue Details page](https://gitcoin.co/issue/status-im/pluto/90/2005).
tpscrpt commented 5 years ago

dang, didnt format that markdown properly :(

StatusSceptre commented 5 years ago

@jeluard @flexsurfer can you help with the above?

jeluard commented 5 years ago

@JeremiGendron As long as pluto.js.parse is usable we are good. See https://github.com/status-im/pluto/blob/master/src/pluto/js.cljs

How do you see this lib being exposed for browser consumers?

tpscrpt commented 5 years ago

Through script inclusion. I'll make an npm package with build/publish logic for distributing an index (node) and a minified script which could be included with unpkg.

On Sun, Dec 16, 2018, 6:52 AM Julien Eluard <notifications@github.com wrote:

@JeremiGendron https://github.com/JeremiGendron As long as pluto.js.parse is usable we are good. See https://github.com/status-im/pluto/blob/master/src/pluto/js.cljs

How do you see this lib being exposed for browser consumers?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/pluto/issues/90#issuecomment-447636945, or mute the thread https://github.com/notifications/unsubscribe-auth/AWfqZQQFphCOcr5Z7fx28wQaIUQcLiqOks5u5jPygaJpZM4YVFjM .

StatusSceptre commented 5 years ago

@JeremiGendron You've been approved to start work.

tpscrpt commented 5 years ago

Thanks, I'll configure it to provide pluto.reader

StatusSceptre commented 5 years ago

@JeremiGendron How are things coming along?

tpscrpt commented 5 years ago

I've been waiting for a review by @jelurad on #117

On Sun, Dec 30, 2018, 12:41 AM StatusSceptre <notifications@github.com wrote:

@JeremiGendron https://github.com/JeremiGendron How are things coming along?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/pluto/issues/90#issuecomment-450540550, or mute the thread https://github.com/notifications/unsubscribe-auth/AWfqZQRSSCWJzBhAJMm5Iy0TvAHMtPPQks5u-FIVgaJpZM4YVFjM .

jeluard commented 5 years ago

@JeremiGendron Sorry forgot that one! Looks great to me! If you could just provide a script or guidance on how to publish to npm that would be perfect!

tpscrpt commented 5 years ago

On it this morning.

On Mon, Dec 31, 2018, 4:49 AM Julien Eluard <notifications@github.com wrote:

@JeremiGendron https://github.com/JeremiGendron Sorry forgot that one! Looks great to me! If you could just provide a script or guidance on how to publish to npm that would be perfect!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/status-im/pluto/issues/90#issuecomment-450626508, or mute the thread https://github.com/notifications/unsubscribe-auth/AWfqZYysoDGAE2RXsUQkMl1QHfI8c9vSks5u-d3GgaJpZM4YVFjM .

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 220.0 DAI (220.0 USD @ $1.0/DAI) has been submitted by:

  1. @jeremigendron

@StatusSceptre please take a look at the submitted work:

jeluard commented 5 years ago

@StatusSceptre Please accept the work! :)

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 220.0 DAI (220.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @JeremiGendron.