status-im / react-native-desktop-qt

A Desktop port of React Native, driven by Qt, forked from Canonical
1.21k stars 85 forks source link

Qt5WebKit missing report in react-native run-desktop #316

Open victormax94 opened 6 years ago

victormax94 commented 6 years ago

Hi, im trying to follow the steps that are in the get start section . i have installed all pre requisites , and when i try to follow the steps of "Create New App" section , in particular at the final step when i do 'react-native run-desktop' im getting issues about missing files , a 'Qt5WebKit'. before that notification of this missing files i had to set manually the path of cmake files in cmake cache like this: image

but i can ' t manually set a qt5WebKit because it doesn't exist . i read the Qt5WebKit is deprecated in Qt 5.9.1 and it was replace by WebEngine. so for this im getting this problem when try to build with react native run desktop: image

Can i solve this? or im doing something wrong? Thank you for the attention.

Environment: OS: Windows 10 Node: 10.9.0 Yarn: 1.9.4 npm: 6.2.0 Watchman: Not Found Xcode: N/A Android Studio: Not Found

Packages: (wanted => installed) react: Not Found react-native: status-im/react-native-desktop => 0.55.4

vkjr commented 6 years ago

Hi @victormax94, Did you have qmake in your path? That should solve the problem of manual setting path to cmake files. from doc: Make sure that installed Qt's qmake tool is available in your PATH.

@maxr, does anything specific should be made to install Qt5WebKit on Windows or it is available via maintenanceTool ?

victormax94 commented 6 years ago

Hi @vkjr , i think, if i understand , windows' users have to use cmake, and in my case i have set the path for this. but i think the main problem is the missing of qt5WebKit , thank you for reply me .

maxhora commented 6 years ago

Qt5WebKit is outdated and not supported officially anymore by Qt, but it's the only option if you're using MinGW based Qt distribution (new WebEngine based on Chromium doesn't support MinGW toolchain, but only MSVC). react-native-desktop currently supports only MinGW based builds, adding of MSVC support is in plans.

Building of Qt5WebKit locally is pretty long time process described there https://github.com/MaxRis/webkit/wiki/Building-QtWebKit-on-Windows-(Conan)

But Qt5WebKit is not mandatory to build react-native-desktop and you should be able to disable dependency on it by turning off CMake option there https://github.com/status-im/react-native-desktop/blob/master/CMakeLists.txt#L28 ( probably, you will need manually to clean up all generated CMake cache files to allow new option value to be applied correctly )

maxhora commented 6 years ago

There was conversation with similar issue building on Windows.

In general, MacOS and Linux support is much more tested at the moment. Windows support enhancements, hopefully, will arrive in upcoming months.

maxhora commented 6 years ago

@victormax94 CMake should know somehow about your Qt installation. Most of all, CMake uses PATH to lookup for qmake on it. Once you will put qmake into your PATH, cmake should locate Qt's libraries automatically without any such issues as you described.