search

status-im / specs

Specifications for Status clients.
https://specs.status.im/
MIT License
14 stars 14 forks source link

mentions #105

Closed yenda closed 4 years ago

oskarth commented 4 years ago

Ping @yenda

oskarth commented 4 years ago

Ping @yenda whats the state of this? It'd be great if we can merge it and create follow up issues where things still need to be done.

oskarth commented 4 years ago

@status-im/status-core @status-im/status-protocol review

oskarth commented 4 years ago

Currently I think we are overspeccing things, for example: tapping it should open the chat with the mentioned user is completely an UI concern. I would not have a separate document for mentions, probably one describing the markdown supported and how is parsed is enough. Having said that, if we are ok with the amount of information, this looks ok to me.

I think that's a fair point. Perhaps it makes sense to amend existing spec and describe "mentions" / ens username there, without going into detail on how the UI should behave?

Samyoul commented 4 years ago

Hey @yenda , the fundamentals of this spec are solid. There are just a few points of clarification I've highlighted that I feel need attention. To be helpful I've written out more details to help with the implementation of these clarifications.

Also perhaps this spec could be renamed as 14-markdown.md if there isn't a dedicated markdown spec, and use the current work as the starting point for a more robust document. If it is too much work to implement this change in the scope of this PR, perhaps we could create an issue to track the need for additional documentation of markdown usage.

yenda commented 4 years ago

@cammellos @Samyoul I took both of your comments into consideration and decided to move the spec to the payloads spec, and remove the implementation details, so that it now consists only of the bare minimum + UX recommendations. Ok to merge?