search

status-im / specs

Specifications for Status clients.
https://specs.status.im/
MIT License
14 stars 14 forks source link

Image content type for chat messages #107

Closed cammellos closed 4 years ago

cammellos commented 4 years ago

Adds a content type for image messages.

For now the supported formats are JPEG, PNG, GIF and WEBP, which should be enough to cover most cases.

Ignore the first commit , as it only copies the stable specs to draft. https://github.com/status-im/specs/pull/107/commits/ca530d9d80681e9d6442fd10cac3e0f2607d88b7

andremedeiros commented 4 years ago

Would be good to have payload limit documented + address multipart (for large images)

cammellos commented 4 years ago

Would be good to have payload limit documented + address multipart (for large images)

Not sure, I would not add multipart as this is not part of image sending or payload in general, we haven't really settled on whether it will be built and which layer it would be taken care of (my gut feelings is that it will be at a much lower layer). Similarly payload has not limit, the limit is dictated by the transport (which should provide multipart if necessary), which is described in a a different document and this doc is probably best to be kept transport agnostic.