search

status-im / specs

Specifications for Status clients.
https://specs.status.im/
MIT License
14 stars 14 forks source link

Dapp browser API usage spec #108

Closed vitvly closed 4 years ago

hesterbruikman commented 4 years ago

What happens when a user withdraws permission? Is that something needs to be included here?

vitvly commented 4 years ago

@hesterbruikman need to investigate what happens then.

flexsurfer commented 4 years ago

we use MM library https://github.com/MetaMask/eth-phishing-detect/blob/master/src/config.json for detecting phishing, probably we should add this in the spec https://github.com/status-im/status-react/blob/a32c94b090bcbe96e3f52c48b1929a76d7c39e0a/src/status_im/browser/core.cljs#L74

flexsurfer commented 4 years ago

Tidus@discord 05/16/2020 on an unrelated note, @Embellished Tangible Darklingbeetle reported in #status that https://audius.co/ was blocked in the Web3 browser here in Status... I confirmed this, and verified that it doesn't occur on any other Web browsers on my iPhone (Brave, Chrome, Coinbase Wallet, DuckDuckGo, Edge, Firefox, Onion, Opera Touch, Safari, SnowHaze, Trust Wallet)... and am now wondering if Status actually somehow maintains a blacklist of domains or blocks them on the fly once they exhibit a certain type of behavior, and if that's in conflict with Principle II (censorship resistance) on https://status.im/about/#our-principles

https://snipboard.io/rGVETW.jpg

oskarth commented 4 years ago

Can we please get a second approval from Core so this can be merged? Discussed a week ago in Core Dev call.

@andremedeiros @vkjr @andremedeiros @flexsurfer @decanus @status-im/status-core

oskarth commented 4 years ago

Thanks @siphiuel and @vkjr!

oskarth commented 4 years ago

Ah right, seems like spell checker in CI (see log) doesn't allow this to be merged. New words have to be added to whitelist https://github.com/status-im/specs/blob/master/wordlist.txt. Could you have a log @siphiuel?

cc @decanus

oskarth commented 4 years ago

@siphiuel please make this pr mergeable, if you need help with spell checker you can ask @decanus

vitvly commented 4 years ago

@oskarth right! Fixed some spelling errors (bidirection -> bidirectional, and acknowledgement -> acknowledgment). For other words added a PR https://github.com/status-im/specs/pull/135.

vitvly commented 4 years ago

@oskarth @decanus fixed spell-check. @decanus - can you please review again?

oskarth commented 4 years ago

@decanus you have to review it, can't dismiss your review since you requested chanages