search

status-im / specs

Specifications for Status clients.
https://specs.status.im/
MIT License
14 stars 14 forks source link

Add spec for IPFS gateway for Sticker Pack #110

Closed Ferossgp closed 4 years ago

andremedeiros commented 4 years ago

Do we know whether the Infura gateway pins the IPFS content?

hesterbruikman commented 4 years ago

Is there a way to add when the method to 3. Get owned stick packs is used? E.g. the instant account is recovered and address is known or upon opening, stickermarket.

Ferossgp commented 4 years ago

@andremedeiros I could not find information if the Infura pins the content by default, but they have a method on the gateway to do that https://infura.io/docs/ipfs/get/pin-add

decanus commented 4 years ago

One thing I am not understanding is why do we store a full URL, rather than the remote ID for a sticker? It seems counter intuitive to store the full URL.

flexsurfer commented 4 years ago

@decanus good question, because as you can see here, https://ipfs.infura.io/ipfs/Qmcehb2dboemjLXDqLZ2V6Vf8w1Z1MVje9QSErERCMMUYs , its a latest stickerpack, we use contenthashes (https://eips.ethereum.org/EIPS/eip-1577), not URLs, we need to change this in spec

decanus commented 4 years ago

@flexsurfer glad we use hashes and not urls, please change in the spec @Ferossgp