search

status-im / specs

Specifications for Status clients.
https://specs.status.im/
MIT License
14 stars 14 forks source link

Added EmojiReaction payload types #145

Closed Samyoul closed 3 years ago

Samyoul commented 3 years ago

Added emoji reaction payload specifications.

For reference see:

I've added these specs to the draft version of 6-payloads because I saw images in drafts and presumed that emoji reactions would also be considered on the same level or lower of spec stability.

oskarth commented 3 years ago

Generally looks good to me, I'll leave this review for Status and core though :) @status-im/security-internal might want to sanity too

oskarth commented 3 years ago

Meta comment

I've added these specs to the draft version of 6-payloads because I saw images in drafts and presumed that emoji reactions would also be considered on the same level or lower of spec stability.

Once it is live it should be marked as stable, because it is a contract with end users as well. I believe @cammellos has done some draft/stable splitting of specs in past to make this distinction clear, so that might be a a good place to look re that.

Samyoul commented 3 years ago

@rajeevgopalakrishna

Looks good to me. Curious - can we apply the same retraction concept from here to messages as well?

We certainly could. In my mind this is the only way to "remove" messages from a p2p system. We need to send some kind of kill signal to peers that would honour the retraction of a message.

Samyoul commented 3 years ago

@oskarth

Once it is live it should be marked as stable, because it is a contract with end users as well. I believe @cammellos has done some draft/stable splitting of specs in past to make this distinction clear, so that might be a a good place to look re that.

Thank you for that meta comment, this is useful information to know.

hesterbruikman commented 3 years ago

Any changes based on the current status-go implementation @Samyoul ?