Document added Whisper packet codes

status-im / specs

Specifications for Status clients.

https://specs.status.im/

MIT License

14 stars 14 forks source link

Document added Whisper packet codes #58

Closed adambabik closed 4 years ago

adambabik commented 4 years ago

We would like to document all Whisper packet codes that extend EIP-627 so that other implementation can be complete in terms of feature set.

Acceptance criteria

Determine which packet codes present in our Whisper fork are actively used.
Document used packet codes with their purpose.

References

Discussion started in https://github.com/status-im/specs/pull/54#discussion_r342635703.

oskarth commented 4 years ago

Any update on this @adambabik? Would be good to get in Waku

Also cc @decanus

adambabik commented 4 years ago

I think we have all packet codes covered now. The only thing is message confirmations which we haven't discussed yet and there is no notion of message confirmation in Waku/0 spec.

oskarth commented 4 years ago

Where? There's an issue but no associated PR, yet you say it is "all covered".

Also if you are working on it, please assign yourself and mark it as TODO/WIP (or done if it is (?))

adambabik commented 4 years ago

@oskarth sorry, we covered that for the Waku spec but not here. I will list all packet codes in https://github.com/status-im/specs/blob/master/status-whisper-usage-spec.md. There is no single place in this document that summaries packet codes.