status-im / specs

Specifications for Status clients.
https://specs.status.im/
MIT License
14 stars 14 forks source link

Replace forked Whisper usage with Waku/0 in specs #61

Closed oskarth closed 4 years ago

oskarth commented 4 years ago

Problem

Currently we use a forked version of Whisper that isn't documented in any great detail. This makes it difficult for other clients to implement and get compatibility with Status clients, e.g. status-nim. It also creates confusion around what requirements and guarantees we have, since we are de facto doing more than EIP627 and this has implications around UX, privacy, DDoS resistance, etc (mailservers, light node, rate limiting).

Acceptance criteria

As well as issues/dependencies marked out for for :

Details

See https://github.com/vacp2p/specs/issues/27 for more details.

This issue is largely dependent on above, but some work can be done in parallel to ease that work. I.e. by documenting customization to Whisper in our current specs, such as:

Possible solutions

See acceptance criteria.

Notes

-

oskarth commented 4 years ago

Blocked by https://github.com/vacp2p/specs/issues/27

oskarth commented 4 years ago

See https://github.com/vacp2p/pm/issues/7 https://github.com/status-im/specs/issues/73

oskarth commented 4 years ago

How is this issue going @samyoul?

cc @andremedeiros

Samyoul commented 4 years ago

Hey. I'll have a PR for this by the end of the day.

Samyoul commented 4 years ago

@oskarth , the initial rewrite PR draft will not be ready today, there are too many refs to outdated things, or things that are sort of relevant or things that need further research to see if there are Waku analogous versions of Whisper terminology etc.

I will open a draft PR of what I've started, reference it here, and I'll keep adding to it until it is complete ready for review. I naively thought it would be a mostly find and replace job. Most of it is, the minority that will take time, isn't.

Samyoul commented 4 years ago

This is the draft https://github.com/status-im/specs/pull/114

Samyoul commented 4 years ago

Finally merged https://github.com/status-im/specs/pull/114