status-im / specs

Specifications for Status clients.
https://specs.status.im/
MIT License
14 stars 14 forks source link

Send images #69

Open rachelhamlin opened 4 years ago

rachelhamlin commented 4 years ago

Image Sending Specs

cc @errorists @flexsurfer :)

User Stories

As a user, I want to send media from my device in 1:1, group and public chats.

POC: https://github.com/status-im/status-react/pull/9455

MVP: Still images only

Technical Requirements

v1, v2: UI enhancements

To be prioritized according to user feedback. Ranked here according to effort/complexity:

Technical Requirements

Future versions: Send video and other files

flexsurfer commented 4 years ago

offtopic: I'm wondering how it worked for avatars, we had pretty huge images for avatars

cammellos commented 4 years ago

We are talking about decreasing the PoW, that's one option. It's a good point for avatars, as a matter of fact I believe many times the image was not sent (it's probabilistic, so you might get lucky every now and then a get it). For example when syncing contacts I had to remove images as they would not be dispatched (I believed at that time it was the size rather than the PoW, but likely it was the PoW instead).

flexsurfer commented 4 years ago

so if we're going waky way my suggestion is to add image sending support only for 1-1 and group chats for the first time and see how it goes, wdyt @andremedeiros @cammellos @hesterbruikman

hesterbruikman commented 4 years ago

so if we're going waky way my suggestion is to add image sending support only for 1-1 and group chats for the first time and see how it goes, wdyt @andremedeiros @cammellos @hesterbruikman

Agreed. Less spam sensitive as well. Is it feasible to offer link unfurling for public chats in parallel?

cammellos commented 4 years ago

Is it feasible to offer link unfurling for public chats in parallel?

This is a feature to be tracked separately, probably best to have a separate conversation, but it has no dependencies on this work.

hesterbruikman commented 4 years ago

Url handling in chat epic for future reference: https://github.com/status-im/status-react/issues/10516