oskarth
commented
4 years ago @corpetty Thanks for the feedback! Could you please do the review in-line? The line numbers are quite confusing and they also change. It is much easier to have a conversation and do suggestions etc in a specific locale. E.g. I noticed you pushed a commit with fixes, but I have no idea what that fixes of your comments.
I know the file diff is a bit off, so you gotta expand to see lines not changed. Even that doesn't work all the time. I suggest pushing a commit with the comment in-line at the appropriate place, then we can comment and discuss on it in-line. WDYT?
This PR moves payloads spec from draft to stable. This means it is an accurate description of what is currently in production for the v1 app.
If we want to do wider changes in the future these should come in the form of SIP issues and PRs, as indicated in the README.
Changes to this spec can still occur but they should be cosmetic ones, errata and clarifications.
Please review with anything factually incorrect or add any relevant data. I want to get this merged over the next 24-48h. This will ensure we have a stable set of specs that accurately reflects what is in production, and then we can proceed from there.