search

status-im / status-components

A set of React/React native components used by Status.im projects
https://status-im.github.io/status-components
7 stars 9 forks source link

Upgraded storybook to v5 #6

Closed eswarasai closed 5 years ago

eswarasai commented 5 years ago

Description

eswarasai commented 5 years ago

@jeluard -- I see that the project has just been created and would love to setup the initial architecture for creating storybook components for respective Status.im UI components.

Before getting started with the development of actual components, I thought it'd be better to setup a basic architecture in place especially linting, CI/CD and react-native support. Let me know your thoughts on this so that I can take up #5 and #3 in the order before proceeding to #2. Thanks!

jeluard commented 5 years ago

@eswarasai Most definitely! Can you share your plan with regard to react-native? Ideally components would have a similar syntax gfor both react and react-native.

eswarasai commented 5 years ago

@jeluard -- I'm going through few example projects for react-native in storybook. Let me know what you think of this project setup -- https://github.com/wix/react-native-storybook-example

Ideally it makes sense to keep storybook for both React and React-Native separate repos. But since the components can be heavily re-used, I'd recommend going with a monorepo setup with packages for react-storybook, react-native-storybook and components. Does this makes sense?

Let me know your thoughts on this and also feel free to add anything that I'm missing. Thanks!

jeluard commented 5 years ago

As much as possible it would be great to have everything in a single source tree. Even sharing code if that's feasible. Something like https://github.com/necolas/react-native-web could be useful? Components would be react-native first then. Also see:

PS Can you squash your commits?

jeluard commented 5 years ago

@eswarasai Note that you have to apply to each individual tasks so that you can be approved.

jeluard commented 5 years ago

Thanks @eswarasai !

eswarasai commented 5 years ago

@jeluard -- Thanks for the quick review and also helpful links for setting up storybook for React-Native. I'll go through them and share a viable option for a monorepo setup.