search

status-im / status-components

A set of React/React native components used by Status.im projects
https://status-im.github.io/status-components
7 stars 9 forks source link

Continues deployment implemented #5 #7

Closed rsercano closed 5 years ago

rsercano commented 5 years ago

Hello,

I was approved as worker of #5, this PR resolves #5, here're the steps to make it work for this repo;

  1. Create a deploy key for github; ssh-keygen -m PEM -t rsa -C "ozdemirsercan27@gmail.com" (without passphrase and use same email with your github)
  2. Go to https://github.com/status-im/status-components/settings/keys, and click “Add deploy key”. Enter a title in the “Title” field, then copy and paste the public key you created in step 1. Check “Allow write access”, then click “Add key”.
  3. Go to https://circleci.com/gh/status-im/status-components/edit#ssh (make sure you're using correct URL :) ), and add the key you created in step 1. In the “Hostname” field, enter “github.com”, and press the submit button
  4. Change line 35 in .circleci/config.yml with your email and username. Change fingerprint at line 39 with the fingerprint which you've got from cicleci.com at step 3.

Let me know for any issue you've encountered

rsercano commented 5 years ago

You may want to squash commits before you merge, was testing a lot.

jeluard commented 5 years ago

Actually can you squash the commits yourself? I can't do it in your repo.

Do you have a URL where I can see the result?

rsercano commented 5 years ago

Of course; here you go; https://rsercano.github.io/status-components/ And here's the circleci; https://circleci.com/gh/rsercano/status-components

For the squash; I suppose there should be an option while merging in github for that

jeluard commented 5 years ago

@rsercano Please squash the commit so that you can choose the commit comment yourself :) Then you can just force push the branch.

rsercano commented 5 years ago

Done @jeluard sorry for the inconvenience :/

jeluard commented 5 years ago

@rsercano I will look at it today. In the meantime could you squash your commits?

rsercano commented 5 years ago

@rsercano I will look at it today. In the meantime could you squash your commits?

Of course @jeluard thank you

rsercano commented 5 years ago

Working on multiple workspaces so GPG signing is a terrible head-ache for me, sorry about that but now it should be fixed.

jeluard commented 5 years ago

Please don't sign, not needed for this repo

rsercano commented 5 years ago

Aight, do you want me to rebase again ? @jeluard

jeluard commented 5 years ago

Please, somehow there are 3 commits in your PR.

rsercano commented 5 years ago

Please check #8