search

status-im / status-components

A set of React/React native components used by Status.im projects
https://status-im.github.io/status-components
7 stars 9 forks source link

#5 circleci ci & cd setup #8

Closed rsercano closed 5 years ago

rsercano commented 5 years ago

Please ignore #7, I just wanted to get rid of this mess and created this PR @jeluard

resolves #5

rsercano commented 5 years ago

Did you have a chance to take a look at this ? @jeluard Sorry to bug you, but this weekend I'm planning to go out of town and this bounty is what I need :) that's because I'm rushing a bit :/

jeluard commented 5 years ago

@jakubgs Can you setup the repo as detailed in #7 ? Do we have an ssh key already maybe?

Also do we have a circleci account ?

jakubgs commented 5 years ago

Why circleci? Can you please explain to me what the outcome is supposed to be?

jeluard commented 5 years ago

This is a library that will be develop by the community that needs full visibility and simplicity from circleci.

No need for Jenkins here

@jakubgs Can you provide me the right github info?

jakubgs commented 5 years ago

Can you provide me the right github info?

What do you need though? I can see you are an admin in this repo so you should have access to https://github.com/status-im/status-components/settings/keys. What else do you need?

jeluard commented 5 years ago

I was assuming we already add those things shared somewhere? Or I can just go ahead and create a new key?

jakubgs commented 5 years ago

Compartmentalization is always good. I'd rather not use the key Jenkins uses connected to our whole org for a project that will use a separate CI. I'd be in favor of adding a new key.

jeluard commented 5 years ago

@jakubgs What I need though is access to the status-im circleci account to add this key, unless there is one added already? I can see some existing project here.

jakubgs commented 5 years ago

I can see some existing project here.

I have no idea what that is. I've never used CircleCI and I don't have any credentials for it.

rsercano commented 5 years ago

It should actually be a github login..

jeluard commented 5 years ago

@rsercano Merging to make sure you can enjoy margaritas this weekend :) I might need your help later on?

@StatusSceptre Can you deliver the bounty?

rsercano commented 5 years ago

I suppose it's working now @jeluard ? :) Would you please release the bounty @StatusSceptre ?

rsercano commented 5 years ago

ping @StatusSceptre