search

status-im / status-console-client

Status messaging console user interface
Mozilla Public License 2.0
10 stars 2 forks source link

Update for status-protocol-go API changes #128

Closed pedropombeiro closed 4 years ago

pedropombeiro commented 4 years ago

This PR integrates the changes from status-im/status-protocol-go#88 and https://github.com/status-im/status-go/pull/1627.

It also updates the console client to Geth 1.9.5.

pedropombeiro commented 4 years ago

Ready for final review.

pedropombeiro commented 4 years ago

@cammellos tiny review please. I'm pointing it to a branch that brings the project to Geth 1.9.5, and the idea is to then merge the whole thing to develop

pedropombeiro commented 4 years ago

This PR also replaces the Go 1.11 build with a Go 1.13 build, because the 1.11 is failing and we don't really need to support that version.

pedropombeiro commented 4 years ago

@adambabik do you have any idea what is causing this build to fail?

adambabik commented 4 years ago

@PombeirP yes, let's update https://github.com/status-im/status-console-client/blob/master/Makefile#L52 to https://github.com/golangci/golangci-lint/releases/tag/v1.20.0 (or 1.19.x which works for 100%, 1.20.0 is a new one I haven't tested in other projects).