status-im / status-console-client

Status messaging console user interface
Mozilla Public License 2.0
10 stars 2 forks source link

Vendor Folder #67

Closed decanus closed 5 years ago

decanus commented 5 years ago

It's usually pretty ugly practice to include folders like vendor in the github repository if this is something every user can easily download with assistance to the package manager.

Unless there is a a reason for this to be include I would vouch for it to be deleted and added to the gitignore.

adambabik commented 5 years ago

In Go it's a normal practice. There is an official support for that with go mod vendor. Currently, we test on Go without Go modules support and vendor/ makes it possible. Also, it speeds up CI pipeline as it does not need to download dependencies from the internet every time.

Source: https://github.com/golang/go/wiki/Modules#how-do-i-use-vendoring-with-modules-is-vendoring-going-away

We may get rid of this folder at some point in the future but for now I would keep it.