search

status-im / status-console-client

Status messaging console user interface
Mozilla Public License 2.0
10 stars 2 forks source link

Joining a chat in Messenger should automatically add a contact #99

Open adambabik opened 5 years ago

adambabik commented 5 years ago

Problem

Currently, when joining a new chat, the contact is not added to the list of contacts but a Whisper subscription is created. This makes it difficult to get messages because Messenger.Messages require a contact to load them.

Solution

Add a contact automatically when joining a chat.

dshulyak commented 5 years ago

it is probably not a big deal in performance, we can add contact automatically, but why app can't explicitly call AddContact rpc method?

adambabik commented 5 years ago

@dshulyak it can but then we would need to return an error if joining a chat that has no associated contact. What I want to avoid is when one joins a chat but Messenger.Messages() returns nothing.