status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
298 stars 78 forks source link

Re-encrypt db screen #10037

Closed alaibe closed 9 months ago

alaibe commented 1 year ago

When re-encryption of the db happens, it may take a lot of time depending on db size, we needs screens for this

Flows when re-encryption happens: migrate profile to keycard convert keycard user to regular keycard change password

@alaibe check if there is a indicator of progress @John-44 @benjthayer design the screens

alaibe commented 1 year ago

As far as I can tell, i don't see anything about getting a progress indicator. However to avoid the infinite spinner, we could do it "Microsoft way". Assume it takes 1 hour and add 1 percent per minute And when it completes, it speed up to the 100%

jrainville commented 1 year ago

IMO Since this is a one time migration, I wouldn't put a huge effort on designing anything. It can just be a message.

alaibe commented 1 year ago

@jrainville for the release it is a one time migration, but see in the description there is other cases where we re-encrypt the db

caybro commented 1 year ago

Any BusyIndicator will do

jrainville commented 1 year ago

Aaaah, you're right. My bad, I read it all fast

iurimatias commented 1 year ago

for the RC this should be something simple, just a message on the UI like "do not turn off the app" etc..

caybro commented 1 year ago

Now imagine this re-encryption running at the same time as the discord import, fun :)

alaibe commented 1 year ago

For this one-off, that should not happen, as the re-encryption is before login

iurimatias commented 1 year ago

simple message added, proper UI to be added in 0.13

squ1sher commented 1 year ago

Note for Automation testing: remove tag @mayfail for: Scenario: The user can change the password and login with new password https://github.com/status-im/status-desktop/blob/master/test/ui-test/testSuites/suite_settings/tst_mainSettingsSection/test.feature#L51

jrainville commented 1 year ago

Do we have a design for this now? @benjthayer

Do we just want a placeholder in the meantime? If we really want to have the design first, then I'd recommend moving this to 0.14

benjthayer commented 1 year ago

Hey @jrainville kicking this off now as a priority. Should have designs ready in the next day or so, allowing time to review with Sale/John

alexandraB99 commented 1 year ago

@benjthayer what is the design status here?

benjthayer commented 1 year ago

@benjthayer what is the design status here?

Hi @alexandraB99 designs were started for this but other items were prioritised.

@John-44 I could loop back to finalise this prior to starting WalletConnect work?

benjthayer commented 1 year ago

Re-encryption designs now complete and added into the relevant existing flows @alexandraB99 @jrainville @saledjenic :

Migrating profile keypair from Keycard to Status https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=15715-371808&mode=design&t=rJ0YF50rEMlafVVb-4

Migrating profile keypair from Status to Keycard https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=7258-182696&mode=design&t=rJ0YF50rEMlafVVb-4

Changing password https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=20164-319037&mode=design&t=rJ0YF50rEMlafVVb-4

saledjenic commented 1 year ago

@benjthayer thanks for the update on this. @alaibe I am pretty sure this is already implemented, QAs @anastasiyaig can confirm.

anastasiyaig commented 1 year ago

@saledjenic it was implemented partially (only 1 scenario was addressed). Please see the designs - there are some changes we discussed in All hands several weeks ago we need to address.

anastasiyaig commented 1 year ago

@saledjenic for example changing password flow in latest master

Screenshot 2023-10-30 at 15 50 53 Screenshot 2023-10-30 at 15 50 45
saledjenic commented 1 year ago

Ok, thanks, then we need to complete it for "Changing password", guess the other 2 are in place.

alexandraB99 commented 11 months ago

@benjthayer for Password Change, I see designs here https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=1646-297422&mode=design&t=QiVEMhvhg9eBComJ-4 and here https://www.figma.com/file/d0G7m8X6ELjQlFOEKQpn1g/Profile-WIP?type=design&node-id=11-106858&mode=design&t=gyA9qpLModHumc5A-4.

Should these be the same thing/flow?

benjthayer commented 11 months ago

@benjthayer for Password Change, I see designs here https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=1646-297422&mode=design&t=QiVEMhvhg9eBComJ-4 and here https://www.figma.com/file/d0G7m8X6ELjQlFOEKQpn1g/Profile-WIP?type=design&node-id=11-106858&mode=design&t=gyA9qpLModHumc5A-4.

Should these be the same thing/flow?

Hey @alexandraB99 yes as part of the recent profile work, we have created a new Password nav item in settings underneath the Profile nav item where change password used to be.

https://www.figma.com/file/d0G7m8X6ELjQlFOEKQpn1g/Profile-WIP?type=design&node-id=11-109778&mode=design&t=ypGuFyfondGMCsnN-4

This replaces the below designs: https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?type=design&node-id=20164-319037&mode=design&t=rdoz3T7HWGEMUp53-4

cc @saledjenic

alexandraB99 commented 9 months ago

Biometrics option to be added here: https://github.com/status-im/status-desktop/issues/13302

anastasiyaig commented 8 months ago

Test cases created: https://ethstatus.testrail.net/index.php?/suites/view/5308&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=56768 Bugs found during testing in master: https://github.com/status-im/status-desktop/issues/13748 https://github.com/status-im/status-desktop/issues/13763 https://github.com/status-im/status-desktop/issues/13747 https://github.com/status-im/status-desktop/issues/13783