search

status-im / status-desktop

Status Desktop client made in Nim & QML
https://status.app
Mozilla Public License 2.0
286 stars 78 forks source link

ScrollView is still scrollable when dragging delegates #10897

Open Cuteivist opened 1 year ago

Cuteivist commented 1 year ago

Bug Report

Description

It is possible to scroll StatusScrollView when you drag StatusListItem. Maybe issue is also happening for other controls.

Steps to reproduce

  1. Go to settings -> Profile
  2. Drag vertically on any control. Scroll view will move few pixels.

Other really interesting case is

  1. Got o Wallet -> any account -> activity -> click delegate with NFT activity
  2. Try scroll view by pressing NFT preview.

This case is unique because scrollview is fully scrollable, not few pixels at the time.

Expected behavior

Scroll View is consistent everywhere and is not possible to scroll it by drag.

Actual behavior

https://github.com/status-im/status-desktop/assets/11396062/c7a52878-76ed-40e3-a76c-e9a1837f79ba

https://github.com/status-im/status-desktop/assets/11396062/688530d3-752b-43a3-b98a-262f6645807e

Additional Information

Cuteivist commented 1 year ago

@igor-sirotin

igor-sirotin commented 1 year ago

Indeed, there's a problem with this. But it seems to be a Qt bug which we can't easily workaround.

ScrollView is excepted not to be "draggable by mouse" (though it should still process real touch screen events). The fact that it's stealing mouse for a moment is a bug that happens when a mouse event takes place in a child of contentItem.

Reference Qt bugs:

Potential workaround

I found a workaround, but the scrolling becomes extremely uncomfortable. Set synchronousDrag: false here: https://github.com/status-im/status-desktop/blob/2a253be291d4c2e8fa86ca93b142edeb3dc08cd4/ui/StatusQ/src/StatusQ/Core/StatusScrollView.qml#L169

What are we gonna do?

IMO, this is not a terrible issue, I could live with it. Though I agree that it looks like it's intended to be draggable. And therefore looks like a bug.

@Cuteivist @jrainville @caybro wdyt?

jrainville commented 1 year ago

What are we gonna do? IMO, this is not a terrible issue, I could live with it. Though I agree that it looks like it's intended to be draggable. And therefore looks like a bug.

@Cuteivist @jrainville @caybro wdyt?

I also think we can live with it for now. I'd move it to 0.14 for now. Maybe even 0.15 if the issue is that annoying to fix for such a small issue

Cuteivist commented 1 year ago

What are we gonna do? IMO, this is not a terrible issue, I could live with it. Though I agree that it looks like it's intended to be draggable. And therefore looks like a bug.

I agree, let's park it for now. We can see in the future whether this issue is noticeable at all for the users.

iurimatias commented 7 months ago

we might not want to do this? cc: @John-44 @benjthayer

benjthayer commented 7 months ago

we might not want to do this? cc: @John-44 @benjthayer

Agree it's not ideal to have scroll on drag randomly in some areas of the app but its perhaps not the highest priority, given it will likely only be discovered by accident and does not have a big impact on the usability of the app. WDYT @John-44 ?

noeliaSD commented 4 months ago

Moved to next milestone due to team capacity and priorities.